Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace https://gitlab.com/pycqa/flake8 with https://github.com/pycqa/flake8 #1388

Closed
JPBergsma opened this issue Nov 15, 2022 · 5 comments
Closed
Labels
CI Continuous Integration - GitHub Actions issues (NOT related to the repository Action) skip_changelog Use this label to omit this PR/issue from the CHANGELOG.

Comments

@JPBergsma
Copy link
Contributor

I noticed that in .pre-commit-config.yaml
we use https://gitlab.com/pycqa/flake8
but in the output under https://github.com/Materials-Consortia/optimade-python-tools/actions/runs/3470260414/jobs/5798242394
subsection run precommit we somehow use: https://github.com/pycqa/flake8
While in testrun https://github.com/Materials-Consortia/optimade-python-tools/actions/runs/3472198532/jobs/5803041964
https://gitlab.com/pycqa/flake8 is used which does not work.
I therefore suggest we change https://gitlab.com/pycqa/flake8 to https://github.com/pycqa/flake8 in .pre-commit-config.yaml

@ml-evs
Copy link
Member

ml-evs commented Nov 15, 2022

I also ran into this yesterday when they finished the flake8 migration, its already fixed in #1373 (just finalizing it now)

@JPBergsma
Copy link
Contributor Author

Do you by any chance also fix a " ModuleNotFoundError: No module named 'yaml'" error in that PR?

@ml-evs
Copy link
Member

ml-evs commented Nov 15, 2022

I haven't run into that one... from a fresh install I have the following:

$ pip freeze | grep yaml
pyyaml_env_tag==0.1
ruamel.yaml==0.17.21
ruamel.yaml.clib==0.2.7

@JPBergsma
Copy link
Contributor Author

I can solve the yaml issue by adding pyyaml to setup.py under install requires.
see PR#1304

@JPBergsma
Copy link
Contributor Author

I'll close this issue as it's topic "Replace https://gitlab.com/pycqa/flake8 with https://github.com/pycqa/flake8" has been resolved.
we can discuss the " ModuleNotFoundError: No module named 'yaml'" error elsewhere like in PR#1304

@ml-evs ml-evs added the CI Continuous Integration - GitHub Actions issues (NOT related to the repository Action) label Nov 29, 2022
@ml-evs ml-evs added the skip_changelog Use this label to omit this PR/issue from the CHANGELOG. label Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration - GitHub Actions issues (NOT related to the repository Action) skip_changelog Use this label to omit this PR/issue from the CHANGELOG.
Projects
None yet
Development

No branches or pull requests

2 participants