Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing guide for how to set up an implementation from existing database #176

Closed
ml-evs opened this issue Feb 10, 2020 · 5 comments · Fixed by #915
Closed

Missing guide for how to set up an implementation from existing database #176

ml-evs opened this issue Feb 10, 2020 · 5 comments · Fixed by #915
Assignees
Labels
docs Issues pertaining to documentation. joss Issues pertaining to the JOSS review of this repository. priority/medium Issue or PR with a consensus of medium priority

Comments

@ml-evs
Copy link
Member

ml-evs commented Feb 10, 2020

We should write some brief instructions on how to go from e.g. a Mongo database of structures with their own field names, to an OPTiMaDe API, mostly explaining which classes should be inherited from/rewritten, and what can be used as is.

@ml-evs ml-evs added the enhancement New feature or request label Feb 10, 2020
@ml-evs ml-evs self-assigned this Feb 10, 2020
@ml-evs ml-evs added docs Issues pertaining to documentation. priority/medium Issue or PR with a consensus of medium priority and removed enhancement New feature or request labels Feb 10, 2020
@CasperWA
Copy link
Member

Sure. Again, this is not relevant if one is not using MongoDB in the backend, e.g., is is not used for AiiDA/MaterialsCloud, but since the standard/example implementation here is based on MongoDB, it sure makes sense for people to want to reuse this repository as a package if they have a MongoDB backend and then some documentation on this would be quite helpful. However, I consider this low-priority, since an implementer can always look into the excellent matador/odbx implementation to see examples of how to do this - right? 😉

@ml-evs
Copy link
Member Author

ml-evs commented Feb 10, 2020

...since an implementer can always look into the excellent matador/odbx implementation to see examples of how to do this - right? wink

Pffff, I hope not...

I agree re: the rest, but I'm imagining just a brief break down of the FilterParser/FilterTransformer/EntryMapper/EntryCollection classes to make it clear we aren't backend-specific.

@ml-evs ml-evs added priority/low Issue or PR with a consensus of low priority and removed priority/medium Issue or PR with a consensus of medium priority labels Feb 10, 2020
@shyamd shyamd added priority/medium Issue or PR with a consensus of medium priority and removed priority/low Issue or PR with a consensus of low priority labels Mar 24, 2020
@CasperWA CasperWA added this to To do in CECAM 2020 via automation Jun 5, 2020
@ml-evs ml-evs moved this from To do to In progress in CECAM 2020 Jun 8, 2020
@jamesrhester
Copy link

(Part of JOSS review)
Just bumping this again.

The one thing missing from the documentation in my view is a simple guide to going from an existing database (of whatever type) to a database serving optimade queries. It seems to me this guide would slot in well under "Getting started"->"A single database". Currently it looks like the user is expected to study how the provided database does it, which is not terrible but could be improved.

@ml-evs
Copy link
Member Author

ml-evs commented Aug 27, 2021

(Part of JOSS review)
Just bumping this again.

The one thing missing from the documentation in my view is a simple guide to going from an existing database (of whatever type) to a database serving optimade queries. It seems to me this guide would slot in well under "Getting started"->"A single database". Currently it looks like the user is expected to study how the provided database does it, which is not terrible but could be improved.

👍

I see I assigned myself on this issue in February 2020, so I guess I have no more excuses... I will prepare something for next week (and will set up the PR so that it closes this issue when merged).

Road to optimade-python-tools 1.0 automation moved this from To do to Done Sep 2, 2021
CECAM 2020 automation moved this from In progress to Done Sep 2, 2021
@ml-evs
Copy link
Member Author

ml-evs commented Sep 2, 2021

I think #915 is sufficient to close this issue @jamesrhester.

I've just pushed a new release, so the expanded "Getting started" section will appear on https://www.optimade.org/optimade-python-tools/getting_started/setting_up_an_api/ imminently.

The previous single db/multi-db stubs have been restructure as "Example use cases" and another guide for integrating within an existing database has been added.

@ml-evs ml-evs added the joss Issues pertaining to the JOSS review of this repository. label Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Issues pertaining to documentation. joss Issues pertaining to the JOSS review of this repository. priority/medium Issue or PR with a consensus of medium priority
Development

Successfully merging a pull request may close this issue.

4 participants