Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance regressions following pydantic update #1835

Closed
ml-evs opened this issue Oct 23, 2023 · 4 comments · Fixed by #1861
Closed

Performance regressions following pydantic update #1835

ml-evs opened this issue Oct 23, 2023 · 4 comments · Fixed by #1861
Labels
bug Something isn't working

Comments

@ml-evs
Copy link
Member

ml-evs commented Oct 23, 2023

Already running into two teething issues with #1745.

  1. Tests now take significantly longer to run (15 mins per Python version) -- will investigate this on a per-test basis.
  2. RAM usage has increased to the point where we can no longer use the Fly.io free-tier (above 256 MB). Will try to debug this too...
This was referenced Oct 23, 2023
@ml-evs ml-evs added the bug Something isn't working label Nov 1, 2023
@ml-evs
Copy link
Member Author

ml-evs commented Nov 1, 2023

After playing around retriggering various old test runs, here's a solid example:

These both ran today so don't think it can be a GH actions perf regression, but I cannot easily explain away the difference between Python versions

@JPBergsma
Copy link
Contributor

It seems like some of the steps are skipped for python 3.10 and 3.11 for the new version(there is (/) infront of the task rather than (✓). For example the step: "Run the optimade client cli" is executed for python 3.9 but not for python 3.10 and 3.11 in the new version.
In the old version it was not executed for python 3.9 and 3.11 but it did get executed for python 3.10. This would explain the timing differences. But I am not sure why some tests get executed one time but not the other time.

@ml-evs
Copy link
Member Author

ml-evs commented Nov 7, 2023

Another reason is that we are using the fly deployment in our client tests (unfortunately down due to the memory usage described above), which by default take a while to timeout!

@ml-evs
Copy link
Member Author

ml-evs commented Nov 7, 2023

Closing this after fixing Fly by using a more lightweight builder with significantly lower mem usage (just enough to creep back into the free tier of Fly)

@ml-evs ml-evs closed this as completed Nov 7, 2023
@ml-evs ml-evs linked a pull request Nov 7, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants