Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

error when browsing OpenAPI docs #192

Closed
ltalirz opened this issue Feb 25, 2020 · 2 comments
Closed

error when browsing OpenAPI docs #192

ltalirz opened this issue Feb 25, 2020 · 2 comments
Labels
OpenAPI OpenAPI / Swagger related issue priority/low Issue or PR with a consensus of low priority
Projects
Road to optimade-python-tools 1.0

Comments

@ltalirz
Copy link
Member

ltalirz commented Feb 25, 2020 •
edited

When clicking on either of the two "Error" schemas on the API docs, after scrolling back up to the top of the page I see this:

Screenshot 2020-02-25 at 14 54 34
@CasperWA
Copy link
Member

CasperWA commented Feb 27, 2020 •
edited

I've been messing around with this for a while now, attempting to adjust the models (see my branch or test it out).
Unfortunately, I cannot make it disappear. Lurking around the web it seems it may be due to circular dependencies, but I find that it's more when we sub-class a model and re-purpose an existing attribute/property. E.g., most (if not all) of the *Response* schemas give errors as well on my side.

@CasperWA CasperWA mentioned this issue Feb 28, 2020
Merged
@CasperWA CasperWA added this to Needs discussion/thought in Road to optimade-python-tools 1.0 Mar 5, 2020
@ml-evs ml-evs added OpenAPI OpenAPI / Swagger related issue priority/low Issue or PR with a consensus of low priority labels Jun 5, 2020
@CasperWA CasperWA changed the title error when browsing API docs error when browsing OpenAPI docs Aug 2, 2020
@CasperWA
Copy link
Member

I don't believe this is any longer the case when using the latest openapi.json from this repository's master branch. Test here.

Road to optimade-python-tools 1.0 automation moved this from Needs discussion/thought to Done Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
OpenAPI OpenAPI / Swagger related issue priority/low Issue or PR with a consensus of low priority
Projects
Road to optimade-python-tools 1.0
  
Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ltalirz @ml-evs @CasperWA