Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query parameters not handled correctly #208

Closed
CasperWA opened this issue Mar 5, 2020 · 0 comments · Fixed by #209
Closed

Query parameters not handled correctly #208

CasperWA opened this issue Mar 5, 2020 · 0 comments · Fixed by #209
Labels
priority/high Issue or PR with a consensus of high priority
Projects
Road to optimade-python-tools 1.0

Comments

@CasperWA
Copy link
Member

CasperWA commented Mar 5, 2020

According to the discussion in Materials-Consortia/OPTIMADE#259, we are not handling the query parameters correctly. Indeed the following should be the case:

URL (Query part) How to handle it
?parameter Return 400 Bad Request
?parameter= Evaluate value as "", i.e., user has deliberately set the parameter with an empty input
?parameter=value Evaluate whether value makes sense for parameter (normal handling)
@CasperWA CasperWA added the priority/high Issue or PR with a consensus of high priority label Mar 5, 2020
@CasperWA CasperWA mentioned this issue Mar 5, 2020
Merged
Road to optimade-python-tools 1.0 automation moved this from In progress to Done Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority/high Issue or PR with a consensus of high priority
Projects
Road to optimade-python-tools 1.0
  
Done
Milestone
No milestone
1 participant
@CasperWA