Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use logging more thoroughly throughout the code base #242

Closed
CasperWA opened this issue Mar 31, 2020 · 1 comment · Fixed by #432
Closed

Use logging more thoroughly throughout the code base #242

CasperWA opened this issue Mar 31, 2020 · 1 comment · Fixed by #432
Labels
enhancement New feature or request priority/low Issue or PR with a consensus of low priority

Comments

@CasperWA
Copy link
Member

Since uvicorn is the chosen server to use, and it runs a nice logging formatting, we should utilize this for any print statements we would want.

This is especially valid for debug messages.
@CasperWA CasperWA added enhancement New feature or request priority/low Issue or PR with a consensus of low priority labels Mar 31, 2020
@CasperWA CasperWA mentioned this issue Mar 31, 2020
Merged
@CasperWA
Copy link
Member Author

This issue depends heavily on the decision/discussion in #248

@ml-evs ml-evs mentioned this issue Jun 5, 2020
Closed
@CasperWA CasperWA mentioned this issue Jul 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request priority/low Issue or PR with a consensus of low priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Introduce logging Materials-Consortia/optimade-python-tools
1 participant
@CasperWA