Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

available_api_versions is not correctly validated #261

Closed
ml-evs opened this issue May 4, 2020 · 1 comment
Closed

available_api_versions is not correctly validated #261

ml-evs opened this issue May 4, 2020 · 1 comment
Assignees
@ml-evs
Labels
schema Concerns the schema models

Comments

@ml-evs
Copy link
Member

ml-evs commented May 4, 2020

Another one arising from @fekad's #258, the validator doesn't currently catch incorrect available_api_version responses, as it allowed

        "available_api_versions": {
          "v0.10.0-dev": "http://www.crystallography.net/cod/optimade/v0.10.0-dev/"
        },

instead of the required list of dicts.
@ml-evs ml-evs added the schema Concerns the schema models label May 4, 2020
@ml-evs ml-evs self-assigned this May 4, 2020
@ml-evs
Copy link
Member Author

ml-evs commented May 4, 2020 •
edited

The model is fine after all, this issue is just a side effect of the validation in #258 expecting a dictionary instead of a list under data, so its contents were not validated.

@ml-evs ml-evs closed this as completed May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ml-evs ml-evs

Labels
schema Concerns the schema models
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ml-evs