Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding markdown links to OpenAPI schema #366

Open
CasperWA opened this issue Jun 24, 2020 · 6 comments
Open

Adding markdown links to OpenAPI schema #366

CasperWA opened this issue Jun 24, 2020 · 6 comments
Labels
docs Issues pertaining to documentation. good first issue Good for newcomers OpenAPI OpenAPI / Swagger related issue priority/low Issue or PR with a consensus of low priority schema Concerns the schema models

Comments

@CasperWA
Copy link
Member

I don't know that it's always preceded by "section", but maybe we can create an issue suggesting adding links to the OpenAPI descriptions and leave it for later to not block the release of v1.0.0-rc.2?

Originally posted by @CasperWA in #351

As seen in the quote above, I tried implementing this already in #351, however, due to the pressing release of v1.0.0-rc.2 of the OPTIMADE API specification, this addition was considered non-essential and too time consuming to implement in that PR.

Instead it has now become this issue, to track the progress of adding the various hyperlinks.

@CasperWA CasperWA added docs Issues pertaining to documentation. good first issue Good for newcomers OpenAPI OpenAPI / Swagger related issue priority/low Issue or PR with a consensus of low priority schema Concerns the schema models labels Jun 24, 2020
@ml-evs
Copy link
Member

ml-evs commented Jul 4, 2020

Where should the links go, to the section in the optimade.rst on GH?

@ml-evs
Copy link
Member

ml-evs commented Jul 4, 2020

Also I think we should do this before we make our next PR to the spec repo, which I guess makes this highish priority...

@CasperWA
Copy link
Member Author

CasperWA commented Jul 4, 2020

Where should the links go, to the section in the optimade.rst on GH?

That was my original intention. However in Materials-Consortia/providers#43 @rartino has suggested to have the specification be hosted outside the github.com domain, which I think makes sense.
@rartino mentioned either putting it under the schema.optimade.org sub-domain or possibly another sub-domain, however, I have suggested to host it directly on the optimade.org website (under "API Specification").
Whatever is decided in the issue (or elsewhere), I think we should point the link to the sections in the specification hosted outside the github.com domain.
Hence, I would consider this issue blocked, if we don't want to do double work.

Or we could say we don't care, and will link to the github.com-hosted specification and be done with it? :)

Either way, yes, to specific link anchors / sections in the specification was my intention.

@ml-evs
Copy link
Member

ml-evs commented Jul 4, 2020

Hmm, maybe we should wait until that is all set up then!

@ml-evs
Copy link
Member

ml-evs commented Jul 4, 2020

(That all sounds good to me though, whatever is decided)

@CasperWA
Copy link
Member Author

Note, an issue of moving the specification under the optimade.org domain has been created here: Materials-Consortia/OPTIMADE#347.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Issues pertaining to documentation. good first issue Good for newcomers OpenAPI OpenAPI / Swagger related issue priority/low Issue or PR with a consensus of low priority schema Concerns the schema models
Projects
None yet
Development

No branches or pull requests

2 participants