Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to pipenv? #37

Closed
ltalirz opened this issue Jun 14, 2019 · 2 comments
Closed

switch to pipenv? #37

ltalirz opened this issue Jun 14, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@ltalirz
Copy link
Member

ltalirz commented Jun 14, 2019

currently, we have a list of required python packages in the setup.py (versions not fixed), and a set of fixed versions in requirements.txt and requirements-optional.txt.

One common issue is that even for fixed packages versions, the versions of dependencies of these packages can still change - this issue is addressed by pipenv.

It turns out we already have a Pipfile in the repository but it isn't mentioned anywhere.

@ml-evs ml-evs added this to Needs discussion/thought in Road to optimade-python-tools 1.0 Nov 4, 2019
@fekad
Copy link
Contributor

fekad commented Nov 4, 2019

Conda env can be also a good alternative too. It is quite easy to use.

@ltalirz ltalirz added the enhancement New feature or request label Jan 8, 2020
@CasperWA
Copy link
Member

CasperWA commented Feb 5, 2020

Closing this issue, as I believe we in other issues have decided to use the current setup, i.e., have ~= specified dependencies in setup.py and then check the dependencies with GitHub Actions CI through special requirements.txt used only for these tests.

@CasperWA CasperWA closed this as completed Feb 5, 2020
Road to optimade-python-tools 1.0 automation moved this from Needs discussion/thought to Done Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

3 participants