Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Landing page wrong URL #371

Closed
shyamd opened this issue Jun 25, 2020 · 2 comments · Fixed by #519
Closed

Landing page wrong URL #371

shyamd opened this issue Jun 25, 2020 · 2 comments · Fixed by #519
Assignees
@ml-evs
Labels
priority/medium Issue or PR with a consensus of medium priority server Issues pertaining to the example server implementation

Comments

@shyamd
Copy link
Contributor

shyamd commented Jun 25, 2020

Landing page doesn't use the base_url when rendering. The links field in the response uses the correct base URL.
@ml-evs
Copy link
Member

ml-evs commented Jul 3, 2020

Related to this, the index_base_url config option doesn't really mean a lot, and is only being used on the landing page now. We should probably remove it.

@ml-evs ml-evs self-assigned this Jul 3, 2020
@ml-evs ml-evs added priority/medium Issue or PR with a consensus of medium priority server Issues pertaining to the example server implementation labels Jul 3, 2020
@CasperWA
Copy link
Member

Would it solve the problem to use the utility function get_base_url()?

@ml-evs ml-evs mentioned this issue Sep 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ml-evs ml-evs

Labels
priority/medium Issue or PR with a consensus of medium priority server Issues pertaining to the example server implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix landing page URL Materials-Consortia/optimade-python-tools
3 participants
@ml-evs @shyamd @CasperWA