Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Heroku cannot handle submodules when deploying via GitHub #373

Closed
CasperWA opened this issue Jun 25, 2020 · 0 comments · Fixed by #374
Closed

Heroku cannot handle submodules when deploying via GitHub #373

CasperWA opened this issue Jun 25, 2020 · 0 comments · Fixed by #374
Assignees
@CasperWA
Labels
bug Something isn't working deployment An app serves the OPTIMADE regular server providers_updates Updates to the Providers Repo

Comments

@CasperWA
Copy link
Member

See Heroku documentation here.

Together with @ml-evs, we have decided to do a mixed solution. Mixed in the sense that we first try to retrieve the file from the submodule, and if this fails we try to retrieve the list of providers from the Materials-Consortia Providers List.
@CasperWA CasperWA added bug Something isn't working deployment An app serves the OPTIMADE regular server providers_updates Updates to the Providers Repo labels Jun 25, 2020
@CasperWA CasperWA self-assigned this Jun 25, 2020
@CasperWA CasperWA mentioned this issue Jun 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CasperWA CasperWA

Labels
bug Something isn't working deployment An app serves the OPTIMADE regular server providers_updates Updates to the Providers Repo
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Retrieve providers list if no submodule is found Materials-Consortia/optimade-python-tools
1 participant
@CasperWA