New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow all types of JSON API relationships #429
Comments
I don't agree with this on the face of it. However, if you understand the specification differently, please try to clarify. |
Indeed.
After consulting JSON API and OPTIMADE specifications yet once more, I now lean towards thinking the same. Thanks for explanation! |
Just my two cents, I agree that to-many relationships were the aim of the specification (and would be my preferred choice for sure), but I'm not sure this is so clear cut in the specification as it stands. The spec just defers to the overall JSON:API relationships definition which contains the sentence:
I would be in favour of adding a note to the specification that restricts our relationships to always be to-many. |
Sure. |
I would not restrict to-many relationships altogether. I would leave sentence "Relationships may be to-one or to-many" as it is (because in the future we may want that for one reason or another), but clarify that |
Currently the validator insists on list-only representations of relationships:
In #397 (comment) @ml-evs and I have agreed that the specification does not limit relationship representations to lists only. Thus both of the following cases should be accepted as valid (citing @ml-evs fine examples):
The text was updated successfully, but these errors were encountered: