Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log_dir option in config is unused #435

Closed
ml-evs opened this issue Jul 31, 2020 · 0 comments · Fixed by #436
Closed

log_dir option in config is unused #435

ml-evs opened this issue Jul 31, 2020 · 0 comments · Fixed by #436
Assignees

Comments

@ml-evs
Copy link
Member

ml-evs commented Jul 31, 2020

Seems like there's some circular dep issue that means that log_dir set in the config is never used; I'd suggest moving the force_debug_log_level from a validator in config to a check when the logger is set up, it loads the config anyway, so if debug is True there, then set the thing to True.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant