Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chemical formulae are not properly validated on model creation #546

Closed
ml-evs opened this issue Oct 8, 2020 · 0 comments · Fixed by #547
Closed

Chemical formulae are not properly validated on model creation #546

ml-evs opened this issue Oct 8, 2020 · 0 comments · Fixed by #547
Assignees
@ml-evs
Labels
models For issues related to the pydantic models directly priority/medium Issue or PR with a consensus of medium priority

Comments

@ml-evs
Copy link
Member

ml-evs commented Oct 8, 2020

Currently, any rubbish can be placed in the chemical formula field when creating a model as we didn't write any validators (!) for them. This is not a massive deal as its an easy thing for implementations to get right, but e.g. chemical_formula_anonymous has strict rules on order that we should enforce.
@ml-evs ml-evs added enhancement New feature or request priority/medium Issue or PR with a consensus of medium priority models For issues related to the pydantic models directly labels Oct 8, 2020
@ml-evs ml-evs self-assigned this Oct 8, 2020
@ml-evs ml-evs mentioned this issue Oct 8, 2020
Merged
@ml-evs ml-evs changed the title Chemical formulae are not properly validated Chemical formulae are not properly validated on model creation Oct 8, 2020
@ml-evs ml-evs removed the enhancement New feature or request label Oct 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ml-evs ml-evs

Labels
models For issues related to the pydantic models directly priority/medium Issue or PR with a consensus of medium priority
Projects
None yet
Milestone
No milestone
1 participant
@ml-evs