Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spurious validation errors in Structure->Species #559

Closed
ml-evs opened this issue Oct 19, 2020 · 0 comments · Fixed by #561
Closed

Spurious validation errors in Structure->Species #559

ml-evs opened this issue Oct 19, 2020 · 0 comments · Fixed by #561
Assignees
@ml-evs
Labels
models For issues related to the pydantic models directly priority/medium Issue or PR with a consensus of medium priority

Comments

@ml-evs
Copy link
Member

ml-evs commented Oct 19, 2020

Validation of Species is throwing some incorrect error messages (and perhaps incorrect errors) on validation of concentration, where the length being compared to is the length of the string "Not Specified" (13) rather than [] when the model has not been fully specified.
@ml-evs ml-evs added priority/medium Issue or PR with a consensus of medium priority models For issues related to the pydantic models directly labels Oct 19, 2020
@ml-evs ml-evs self-assigned this Oct 19, 2020
@ml-evs ml-evs mentioned this issue Oct 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ml-evs ml-evs

Labels
models For issues related to the pydantic models directly priority/medium Issue or PR with a consensus of medium priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Species validators and error messages Materials-Consortia/optimade-python-tools
1 participant
@ml-evs