Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versioning models independently of this package #609

Open
ml-evs opened this issue Nov 20, 2020 · 1 comment
Open

Versioning models independently of this package #609

ml-evs opened this issue Nov 20, 2020 · 1 comment
Assignees
Labels
models For issues related to the pydantic models directly needs discussion suggestions

Comments

@ml-evs
Copy link
Member

ml-evs commented Nov 20, 2020

Following the comments around maintaining two parallel releases of the specification, we should have a discussion about how we want to version our models in the future.

Is the API stable enough to be able to pluck the models out into a separate repository where they can be versioned as releases, or does this add too much overhead on what will hopefully be fairly static objects? [additionally two model versions could not be used simultaneously with this approach]

Should we explicitly add logic for versioning models in this package, e.g. extend OptimadeField to include some kind of "supported versions" attribute per field, so that different implementations can be validated (for example) with different model versions?

Paraphrased from post by @ml-evs in #593 (comment)

@ml-evs ml-evs added models For issues related to the pydantic models directly needs discussion suggestions labels Nov 20, 2020
@shyamd
Copy link
Contributor

shyamd commented Jan 5, 2021

This is another reason to switch to namespace packages. To have a single repo with multiple packages in it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
models For issues related to the pydantic models directly needs discussion suggestions
Projects
None yet
Development

No branches or pull requests

2 participants