Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish workflow fails when no changes to api docs between versions #673

Closed
ml-evs opened this issue Jan 15, 2021 · 0 comments · Fixed by #674
Closed

Publish workflow fails when no changes to api docs between versions #673

ml-evs opened this issue Jan 15, 2021 · 0 comments · Fixed by #674
Labels
bug Something isn't working CI Continuous Integration - GitHub Actions issues (NOT related to the repository Action)

Comments

@ml-evs
Copy link
Member

ml-evs commented Jan 15, 2021

Just ran into this at https://github.com/Materials-Consortia/optimade-python-tools/actions/runs/488548054.

If the API docs have no updates between versions (as in 0.12.7) then the changes to the changelog will cause the workflow to try and make an empty commit. The line below does not filter out the case where CHANGELOG has been modified (by the workflow) but API docs have no changes:

if [ -n "$(git status --porcelain --untracked-files=no --ignored=no)" ]; then

@ml-evs ml-evs added bug Something isn't working CI Continuous Integration - GitHub Actions issues (NOT related to the repository Action) labels Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CI Continuous Integration - GitHub Actions issues (NOT related to the repository Action)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant