Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom configuration extensions & use standard pydantic way of loading config file #739

Closed
CasperWA opened this issue Mar 9, 2021 · 0 comments · Fixed by #740
Closed

Custom configuration extensions & use standard pydantic way of loading config file #739

CasperWA opened this issue Mar 9, 2021 · 0 comments · Fixed by #740
Assignees
@CasperWA
Labels
config For issues/PRs related to the server config. enhancement New feature or request server Issues pertaining to the example server implementation

Comments

@CasperWA
Copy link
Member

CasperWA commented Mar 9, 2021

It would be nice to be able to extend the configuration class with custom configuration options, but this is currently not allowed (extra attribute in embedded Config class).

Furthermore, pydantic seems to have a more "standard" way of loading a config file than what we're doing. It might be worth testing out.
@CasperWA CasperWA added enhancement New feature or request server Issues pertaining to the example server implementation labels Mar 9, 2021
@CasperWA CasperWA self-assigned this Mar 9, 2021
@CasperWA CasperWA mentioned this issue Mar 9, 2021
Merged
@CasperWA CasperWA added the config For issues/PRs related to the server config. label Mar 15, 2021
@ml-evs ml-evs mentioned this issue Mar 15, 2021
Merged
9 tasks
@ml-evs ml-evs mentioned this issue Mar 26, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CasperWA CasperWA

Labels
config For issues/PRs related to the server config. enhancement New feature or request server Issues pertaining to the example server implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Config updates CasperWA/optimade-python-tools
1 participant
@CasperWA