Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify that missing values are not returned in comparisons #792

Closed
ml-evs opened this issue May 7, 2021 · 1 comment · Fixed by #796
Closed

Verify that missing values are not returned in comparisons #792

ml-evs opened this issue May 7, 2021 · 1 comment · Fixed by #796
Labels
priority/medium Issue or PR with a consensus of medium priority server Issues pertaining to the example server implementation tests Related to tests transformers Related to all filter transformers

Comments

@ml-evs
Copy link
Member

ml-evs commented May 7, 2021

(MongoDB's NOT will also return documents with missing values which is not allowed accoording the OPTMIADE standard. An alternative would be to add an extra expression to check wether a certain entry is present in a Document.

This is a good point that we may not be testing currently (I believe we only test "required" fields in our filter tests, which cannot be null/missing). As you say, a remedy may be to add an {"$exists": True} to every comparison we perform. I think I will raise another issue for this, as we should also test that the elasticsearch backend behaves appropriately.

Originally posted by @ml-evs and @JPBergsma in #79 (comment)

@ml-evs ml-evs added priority/medium Issue or PR with a consensus of medium priority server Issues pertaining to the example server implementation tests Related to tests transformers Related to all filter transformers labels May 7, 2021
@ml-evs
Copy link
Member Author

ml-evs commented May 7, 2021

I think I will quickly knock up a test for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/medium Issue or PR with a consensus of medium priority server Issues pertaining to the example server implementation tests Related to tests transformers Related to all filter transformers
Projects
None yet
1 participant