Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move run.sh to a python file to be environment-agnostic #81

Closed
CasperWA opened this issue Nov 14, 2019 · 4 comments
Closed

Move run.sh to a python file to be environment-agnostic #81

CasperWA opened this issue Nov 14, 2019 · 4 comments
Assignees
Labels
good first issue Good for newcomers priority/low Issue or PR with a consensus of low priority

Comments

@CasperWA
Copy link
Member

It may be prudent to move from the current run.sh file to a run.py similar to this one written by @fekad.

This will make it easier to develop in a Windows environment as well, but mostly simply remove any obvious OS environment dependency, although it may still be present indirectly.

@CasperWA CasperWA added the good first issue Good for newcomers label Nov 14, 2019
@fekad
Copy link
Contributor

fekad commented Nov 14, 2019

It could be useful for debugging in PyCharm (which available for any OS) as well. As far as I know, you cannot activate the visual debuger mode when you run it from the bash.

@CasperWA CasperWA changed the title Move run.sh to a python file for be environment-agnostic Move run.sh to a python file to be environment-agnostic Dec 2, 2019
@CasperWA
Copy link
Member Author

If this is done, one should be aware that the location of local_*openapi.json files will most likely change. One should take care not to change the default location (which is the package root).

@CasperWA CasperWA added the priority/low Issue or PR with a consensus of low priority label Feb 5, 2020
@CasperWA CasperWA added this to Needs discussion/thought in Road to optimade-python-tools 1.0 Mar 5, 2020
@CasperWA
Copy link
Member Author

CasperWA commented Jun 5, 2020

Adding a __name__ = '__main__' section to main.py, importing unicorn within the if-sentence will support debugging and development in a broader sense, while not disturbing other development frameworks.

@fekad
Copy link
Contributor

fekad commented Jun 8, 2020

This is an old issue and with the current structure of the tool, it doesn't make sense to do modifications.

@fekad fekad closed this as completed Jun 8, 2020
Road to optimade-python-tools 1.0 automation moved this from Needs discussion/thought to Done Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers priority/low Issue or PR with a consensus of low priority
Development

No branches or pull requests

2 participants