Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure all validators are tested #87

Closed
CasperWA opened this issue Nov 20, 2019 · 1 comment
Closed

Make sure all validators are tested #87

CasperWA opened this issue Nov 20, 2019 · 1 comment

Comments

@CasperWA
Copy link
Member

Should we also change all these other validators to ValueError?

Originally posted by @ml-evs in #83

We should probably make all AttributeErrors ValueErrors?
@CasperWA
Copy link
Member Author

All validators has been changed to raise ValueError in PR #91.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@CasperWA