Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate static documentation on github from openapi.json #9

Closed
ltalirz opened this issue Jun 12, 2019 · 7 comments
Closed

generate static documentation on github from openapi.json #9

ltalirz opened this issue Jun 12, 2019 · 7 comments
Assignees

Comments

@ltalirz
Copy link
Member

ltalirz commented Jun 12, 2019

No description provided.

@dwinston
Copy link
Contributor

One option is to just provide a link such as https://redocly.github.io/redoc/?url=https://raw.githubusercontent.com/Materials-Consortia/optimade-python-tools/master/openapi.json.

@ltalirz
Copy link
Member Author

ltalirz commented Jun 12, 2019

I like this option, and it is hosted on github as well.

Can still make sense to have way to show the docs locally for development purposes.
Github pages are kind of optional at this point...

@ltalirz
Copy link
Member Author

ltalirz commented Jun 13, 2019

@ltalirz
Copy link
Member Author

ltalirz commented Jun 22, 2019

@dwinston since there is an open PR #46 for this, can we perhaps reach a decision on whether to merge this or not?
After whatever decision is taken, this issue can be closed.

@dwinston
Copy link
Contributor

@ltalirz okay, I'll take a closer look at the PR tomorrow. I suspect the perfect is the enemy of the good here, and I will opt to approve.

@dwinston
Copy link
Contributor

I left feedback on PR #46. I'd like to close this issue, as we have "instant" links to pretty-view the openapi.json spec in our README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants