Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No error/warning when specifying a config file that does not exist #930

Closed
ml-evs opened this issue Sep 1, 2021 · 0 comments · Fixed by #931
Closed

No error/warning when specifying a config file that does not exist #930

ml-evs opened this issue Sep 1, 2021 · 0 comments · Fixed by #931
Assignees
@ml-evs
Labels
bug Something isn't working config For issues/PRs related to the server config.

Comments

@ml-evs
Copy link
Member

ml-evs commented Sep 1, 2021 •
edited

Specifying a garbage file name raises no warning (and even says it loaded correctly), e.g.,

$ OPTIMADE_CONFIG_FILE=optimade_config.jsosdfn uvicorn optimade.server.main:app
INFO:     [optimade] Using: Mock MongoDB (mongomock)
INFO:     [optimade] Loaded settings from optimade_config.jsosdfn.
@ml-evs ml-evs self-assigned this Sep 1, 2021
@ml-evs ml-evs added bug Something isn't working config For issues/PRs related to the server config. labels Sep 1, 2021
@ml-evs ml-evs changed the title No error when specifying a config file that does not exist No error/warning when specifying a config file that does not exist Sep 1, 2021
@ml-evs ml-evs mentioned this issue Sep 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ml-evs ml-evs

Labels
bug Something isn't working config For issues/PRs related to the server config.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix config file warnings when file is missing Materials-Consortia/optimade-python-tools
1 participant
@ml-evs