Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle include standard JSON API query parameter #94

Closed
CasperWA opened this issue Nov 27, 2019 · 0 comments · Fixed by #163
Closed

Handle include standard JSON API query parameter #94

CasperWA opened this issue Nov 27, 2019 · 0 comments · Fixed by #163
Assignees
@CasperWA
Labels
priority/high Issue or PR with a consensus of high priority schema Concerns the schema models
Projects
Road to optimade-python-tools 1.0
Milestone
OPTiMaDe v0.10.1

Comments

@CasperWA
Copy link
Member

CasperWA commented Nov 27, 2019 •
edited

See OPTiMaDe spec repo issues #212 and #183, and look out for an upcoming PR.

The PR has been merged and was Materials-Consortia/OPTIMADE#219.

We should handle the JSON API query parameter include.
@CasperWA CasperWA added the schema Concerns the schema models label Nov 27, 2019
@CasperWA CasperWA added this to To do in Road to optimade-python-tools 1.0 via automation Nov 27, 2019
@CasperWA CasperWA added this to the OPTiMaDe v0.10.1 milestone Dec 22, 2019
@CasperWA CasperWA changed the title Updates to top-level included and the include query parameter are coming Handle include standard JSON API query parameter Feb 3, 2020
@CasperWA CasperWA self-assigned this Feb 5, 2020
@CasperWA CasperWA mentioned this issue Feb 5, 2020
Merged
@CasperWA CasperWA added the priority/high Issue or PR with a consensus of high priority label Feb 5, 2020
@CasperWA CasperWA moved this from To do to In progress in Road to optimade-python-tools 1.0 Feb 6, 2020
Road to optimade-python-tools 1.0 automation moved this from In progress to Done Feb 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CasperWA CasperWA

Labels
priority/high Issue or PR with a consensus of high priority schema Concerns the schema models
Projects
Road to optimade-python-tools 1.0
  
Done
Milestone
OPTiMaDe v0.10.1
Development

Successfully merging a pull request may close this issue.

Implement include query parameter CasperWA/optimade-python-tools
1 participant
@CasperWA