Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config issue #3

Closed
marcodigennaro opened this issue Jun 19, 2023 · 5 comments
Closed

config issue #3

marcodigennaro opened this issue Jun 19, 2023 · 5 comments

Comments

@marcodigennaro
Copy link
Collaborator

After creating a test project, jf project check returns An Error occurred during the command execution: KeyError 'type'
We have tried to explicitly insert the mongostore as and as_dict() into the test.yaml file but we find inconsistent responses. Please check the attachments.

Screenshot 2023-06-19 at 11 10 25
Screenshot 2023-06-19 at 11 26 13

@gpetretto
Copy link
Contributor

Hi @marcodigennaro, thanks for reporting this. First a quick check. Which version of jobflow is installed? If it is the one installed with pip it may miss a bug fix. If that is the case, can you try again using the latest development version form https://github.com/materialsproject/jobflow? If is already the latest development version, can you send me an anonimized version of the config file?

@marcodigennaro
Copy link
Collaborator Author

it's the develop branch from github

@davidwaroquiers
Copy link
Member

For jobflow-remote, it's the develop branch, but jobflow itself is the one from pypi.

@gpetretto
Copy link
Contributor

Then it is missing your fix: materialsproject/jobflow#331. I checked with Marco's project file and indeed I don't have that error. Admittedly I thought it would have worked even without it, but I have the latest version of jobflow in my test environment, so I did not realize that there was an issue.
Since the fix is already in place in jobflow I don't think it is worth changing jobflow-remote, but rather starting using the most recent version of jobfow.
@marcodigennaro can you try that?
@utf do you think it could be a good time to have a new jobflow release?

@marcodigennaro
Copy link
Collaborator Author

I installed jobflow from git (main branch) and it works indeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants