-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Which registered version is saved? #106
Comments
Hi @ciaobladoo, Best, |
Thanks, Chandler. What if I also do micro-registration after rigid/non-rigid registration? |
If you do micro-registration after rigid/non-rigid registration, then the non-rigid transformation parameters get updated, so the default would still be to save the non-rigidly aligned images. |
Is rigid micro-registration necessary for non-rigid micro-registration? It seems rigid micro-registration takes an awful amount of time. |
I am using 0.05 as micro-registration fraction. The micro rigid registration is extremely slow. Here is the output. `Aligning AVD-44AOK-4698_1 to AVD-44AOK-4698-1_1008013. ROI width, height is [ 5109.33891213 5340.61272476] pixels PROCESSING TASKS | : 3%|██▏ | 3/110 [43:41<35:06:05, 1180.98s/it]/home/ssm-user/venv/myenv/lib/python3.10/site-packages/valis/valtils.py:24: UserWarning: Need at least 4 keypoints for RANSAC filtering, but only have 2 Any idea why it should be this slow (I am using AWS so it's possible I need a better configuration of memories, etc.)? Thank you! |
Hi @ciaobladoo,
When I run this on my 2021 M1 macbook pro, it takes about 5 seconds per tile, which does seem much faster, so I guess it might also have something to do with AWS too? To answer your other question, the rigid micro-registration is not needed to perform non-rigid micro-registration. In fact, if the rigid micro-registration doesn't produce better results (more matches that are closer together after registration), then the rigid micro-registration results are "thrown out", and the lower resolution results are kept. The error estimates from micro rigid registration should be more accurate, and the high resolution results can be better than the lower resolution ones, but it isn't always the case. So, if speed isn't an issue, it doesn't hurt to try rigid micro-registration because the best rigid transforms are kept. However, the differences may be small and when speed is an issue rigid micro-registration might not be worth it. Best, |
Thanks, Chandler. I am trying this again on Databricks. Apologize for discussing a different issue here. But here is the error I got trying to do micro-registration. Traceback (most recent call last): Any idea what could have caused this? Thank you so much! Chao |
Dear Chandler,
I am a bit confused about which registered version are saved when running
registrar.warp_and_save_slides(registered_slide_dst_dir, crop="overlap")
if I did both rigid and non-rigid registration (and what if I did micro-registration in addition?)
Thanks!
Chao
The text was updated successfully, but these errors were encountered: