Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

versionCode is not increased #25

Closed
IzzySoft opened this issue Aug 25, 2022 · 8 comments
Closed

versionCode is not increased #25

IzzySoft opened this issue Aug 25, 2022 · 8 comments

Comments

@IzzySoft
Copy link

While your latest release is tagged v1.1.0, your build.gradle still has versionCode:1 and versionName: "1.0". Could you please adjust that for future releases? For some background:

  • versionCode: what Android uses to tell versions apart. Two APKs with the same versionCode are considered being the same. No update notification/offer will be made. So today's update reached my repo, but existing users won't notice 😱
  • versionName: what the user gets to see. If that stays the same, users can never tell which version they're running. Not only bad for their updates, but also for their issue filings 😉

Thanks in advance for taking care!

@MathRoda
Copy link
Owner

Hello @IzzySoft Thank you for the issue, i totally forgot to change it 😥
i'll try to release soon with the update, take care dude

@IzzySoft
Copy link
Author

Thanks! Then it'll solve itself with the update. And if you remember in the future, the issue won't arise again 😜

@MathRoda
Copy link
Owner

hahah I'll sure do

@IzzySoft
Copy link
Author

MayI remind you to do it "really sure? Your latest release (from August 25) still confusing my updater, as it still identifies with a version not matching the tag name: tag = v1.1.0, app = v1.0 and versionCode: 1. I'll hence now have to disable update checks. Please give me a ping when a fixed release is available. Thanks!

@IzzySoft
Copy link
Author

IzzySoft commented Feb 4, 2023

Well, I doubt it will ever be done. Updates are disabled for your app in my repo until solved. Please give me a ping then so I can check and re-enable them, @MathRoda

@MathRoda
Copy link
Owner

@IzzySoft #49

@IzzySoft
Copy link
Author

Thanks! Will the next release have a signed APK attached again then? v2.0.0 only has an app-release-unsigned.apk. Then I may hopefully re-enable updates for my repo.

@IzzySoft
Copy link
Author

IzzySoft commented Dec 3, 2023

Hi @MathRoda, sad news. I had to remove DashCoin from my repo for now. Not because the APK at the latest release (v2.3.0) still/again does not match its versionName (2.2.0) and thus auto-updates fail, but because of

Offending libs:
---------------
* Play Services SafetyNet (/com/google/android/gms/safetynet): NonFreeComp,NonFreeNet
* Google Mobile Services (/com/google/android/gms): NonFreeComp
* Google App Engine (/com/google/appengine): NonFreeNet
* Cloud Audit Logs (/com/google/cloud/audit): Tracking
* Google Cloud Logging Client for Java (/com/google/cloud/logging): NonFreeNet
* Firebase (/com/google/firebase): NonFreeNet,NonFreeComp
* firebase-firestore (/com/google/firebase/firestore): NonFreeDep,NonFreeNet

7 offenders.

That exceeds the numbers tolerated in my repo, so I can no longer keep it up there. Should you have a "liberated" build available, I gladly see that I can re-establish it, just let me know then – but for now, with the next sync around 7 pm UTC it will disappear from my repo. Sorry for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants