New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(servidor): autorización #91
Open
MatiasOlivera
wants to merge
62
commits into
develop
Choose a base branch
from
feature/servidor-autorizacion
base: develop
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
La aplicación va a tener un login para los clientes y otro para los empleados
Utilizar un nombre de modelo más específico y no tan genérico
El cliente usuario debe tener asociado un cliente
Este rol se va a utilizar para testing y va a ser asignado a nuestro usuario del sistema
Evitar probar la autorización (permisos) y la lógica de negocio en el mismo archivo
La comprobación va a ser utilizada en todas las políticas de los modelos relacionados con cliente
Los tests estaban superando el límite de peticiones por minuto configurado en Laravel. https://phpunit.readthedocs.io/en/8.5/fixtures.html#sharing-fixture
Al convertir un float a string, usando el cast (string) se eliminan los ceros de la parte decimal. Si se usa el método number_format se puede establecer los digitos de la parte decimal. (string) 10.50 // "10.5" number_format(10.50, 2, '.', '') // "10.50"
MatiasOlivera
added
nueva característica
New feature or request
refactoring
Further information is requested
labels
Feb 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Agregado
UsuarioTienePermiso
Cambiado
ProductosController
: devolver favoritos solo si el usuario es clienteProductoResource
:es_favorito
solo si el usuario es clienteArreglado
ClienteRazonSocial
: evitar consultar la relación localidad ya que no existeCliente
yEmpleado
: corregir foráneas de la relación cotizacionesEliminado
Fixes #85
Fixes #87