Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Malformed JSON #331

Closed
InterstellarRaccoon opened this issue Apr 21, 2019 · 9 comments
Closed

Malformed JSON #331

InterstellarRaccoon opened this issue Apr 21, 2019 · 9 comments

Comments

@InterstellarRaccoon
Copy link

Loading Harvestcraft on 1.12.2zc throws an error about malformed JSONs and true enough, there is some weird syntax on them. They are

cucumbersandwichitem with a misplaced comma

{
  "result": {
    "item": "harvestcraft:cucumbersandwichitem"
  },

  "ingredients": [
    {
      "type": "forge:ore_dict",
      "ore": "toolCuttingboard"
    },
,
{
      "item": "minecraft:bread"
    }
{
      "type": "forge:ore_dict",
      "ore": "cropCucumber"
    },
{
      "type": "forge:ore_dict",
      "ore": "foodCheese"
    },
{
      "type": "forge:ore_dict",
      "ore": "listAllheavycream"
    }
  ],
  "type": "forge:ore_shapeless"
}

and cassouletitem with a missing double quote

{
  "result": {
    "item": "harvestcraft:cassouletitem"
  },

  "ingredients": [
    {
      "type": "forge:ore_dict",
      "ore": "toolPot"
    },
{
      "type": "forge:ore_dict",
      "ore": "listAllduckraw"
    },
{
      "type": "forge:ore_dict",
      "ore": "foodSausage"
    },
{
      "type": "forge:ore_dict",
      "ore": "listAllporkraw"
    },
{
      "type": "forge:ore_dict",
      "ore": "cropBean"
    },
{
      "type": "forge:ore_dict",
      "ore": cropOnion"
    },
{
      "type": "forge:ore_dict",
      "ore": "cropSpiceleaf"
    },
{
      "type": "forge:ore_dict",
      "ore": "cropGarlic"
    },
{
      "type": "forge:ore_dict",
      "ore": "cropCarrot"
    }
  ],
  "type": "forge:ore_shapeless"
}
@miiichael
Copy link

This is where I confess that I haven't actually gotten around to deploying this fix to my own server yet. 😅

My advice is to either wait patiently for Pam (hopefully not still dealing with health-related dramas) to accept my pull request, or non-novices could have a go at monkey-patching the mod themselves, by unpacking the .jar with one's favourite zip file utility, editing the bugged files appropriately, and then re-zipping the whole lot up back into a .jar file again. (Of course, it goes without saying that if you break your server in the process, you get to keep both pieces :P)

Definitely not a critical issue; it's fine to do nothing for now. The items (and stuff that depends on those items, such as High Tea) will become craftable once the mod is updated with the fix.

@miiichael
Copy link

On the bright side, I have now tested (successfully!) my fix on my own server. 😄

@Pythonic-Rainbow
Copy link

My server stuck after throwing parse error..

@miiichael
Copy link

This bug only breaks two recipes (adding a couple of error messages to the logs in the process), not the entire server. I'd say your broken modpack will likely be due to a different issue...

@MatrexsVigil
Copy link
Owner

Fixed in upcoming 1.12.2zd

And updates have been taking longer because I had an issue with a 7mm kidney stone and then when they removed the stent after that surgery, I had 11-13 1-3mm kidney stones come out in 24 hours. Health issues suck! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants
@miiichael @MatrexsVigil @Pythonic-Rainbow @InterstellarRaccoon and others