New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Line wrapping fixes #149
Line wrapping fixes #149
Conversation
the md->rfc process doesn’t auto-linewrap inserted code, so these xml were exceeding the allowed 72 char width. Intended to resolve #148
breaks alignment but fixes compliance with chars-per-line limit
@@ -320,7 +320,7 @@ The path defines the allowed storage locations of the `EBML Element` within an ` | |||
The `path` attribute is REQUIRED. | |||
|
|||
``` | |||
EBMLFullPath = EBMLElementOccurrence "(" EBMLReferencePath ")" | |||
EBMLFullPath = EBMLElementOccurrence "(" EBMLReferencePath ")" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LUTM, but fixes the issue (U = ugly ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i can't think of a better idea, unless @robUx4 wants to rename one of these components to use a shorter string length.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless @retokromer comes with something less U, I think it's fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could also resolve by renaming VariableParentOccurrence
to VarParentOccurrence
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I don’t have a proposal having less U. As Dave said, only shorter names would prevent it. That said, this fixes the issue of the «miniature pages».
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think shorter names are less U
than breaking alignment.
fixes #148 |
LGTM although it might break the ugly code that's generating various code from the XML source. |
breaks alignment but fixes compliance with chars-per-line limit