Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix -DEbml_DIR=/path/to/libebml in the README #73

Closed
robUx4 opened this issue Sep 25, 2022 · 2 comments
Closed

Fix -DEbml_DIR=/path/to/libebml in the README #73

robUx4 opened this issue Sep 25, 2022 · 2 comments
Labels

Comments

@robUx4
Copy link
Contributor

robUx4 commented Sep 25, 2022

The Ebml_DIR option mention in the README.md doesn't exist and is ignored. I'm not sure what it the correct way to signal this (some combination of CMAKE_MODULE_PATH probably).

@robUx4 robUx4 added the bug label Sep 25, 2022
@mbunkus
Copy link
Contributor

mbunkus commented Sep 25, 2022

It's called EBML_DIR and works, but you often would rather use CMAKE_INSTALL_PREFIX.

For example, if you build & install libEBML like this:

cmake -DCMAKE_INSTALL_PREFIX=$HOME/opt/ebmlmatroska -DBUILD_SHARED_LIBS=no ..

you'll likely want to install libMatroska into the same directory, hence:

cmake -DCMAKE_INSTALL_PREFIX=$HOME/opt/ebmlmatroska -DBUILD_SHARED_LIBS=no ..

That suffices for both detection & setting the target directory.

However, this also compiles, but still installs in the default directory:

cmake -DEBML_DIR=$HOME/opt/ebmlmatroska/lib/cmake/EBML -DBUILD_SHARED_LIBS=no ..

@robUx4
Copy link
Contributor Author

robUx4 commented Sep 25, 2022

Indeed, it works when not setting CMAKE_INSTALL_PREFIX, otherwise it warns that the Ebml_DIR parameters has not been used.

@robUx4 robUx4 closed this as completed Sep 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants