Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Search for any biome of specific category #134

Open
grayfallstown opened this issue May 21, 2022 · 5 comments
Open

Feature Request: Search for any biome of specific category #134

grayfallstown opened this issue May 21, 2022 · 5 comments

Comments

@grayfallstown
Copy link

Currently, I am looking for any biome of the mountains or extreme hills categories.
It would be great if I could do this more easily with this mod.

@Philipp0205
Copy link

Philipp0205 commented Jan 29, 2023

I would like to see this feature as well, so I looked at the code and found a very straightforward way to implements this.

If there is any interest in this, I could create a Pull Request @MattCzyr .

There are a few things to note: The "Search By" button cycles through the ISorting<?> interfaces the same way as the sort button does, and only searches the text.
For rainfall and temperature, this is not optimal because one may want to search for biomes with a temperature higher than a threshold.

Edit: I was working on the 1.18.2 version (because I play ATM 7) and I just saw that the 1.19.2 Version offers a new search syntax. "@" to search the biome tags and "$" to search the source. But both do not work for me?

2023-01-29.15-34-17.mp4

@MattCzyr
Copy link
Owner

@Philipp0205 The "@" and "$" syntax that you're talking about was just merged a couple weeks ago, and I haven't yet released a new version with that change yet. So once a new version is released, this feature request will be complete.

@Philipp0205
Copy link

Philipp0205 commented Jan 31, 2023

@MattCzyr Perfect 👍 Than no work is needed here.

I noticed that there are a few open issues that could use some attention, and I'd be happy to help. However, I understand if you prefer to handle everything on your own :)

@MattCzyr
Copy link
Owner

MattCzyr commented Feb 3, 2023

@Philipp0205 Most of the open issues are either not for the latest Minecraft version or don't contain enough info to replicate, so they're not a high priority for me. But if there's any issues you'd like to work on, it's much appreciated. Except maybe the enhancement requests, wouldn't want you to spend time working on a feature that I've already decided not to implement. :)

@Philipp0205
Copy link

@MattCzyr Do you mean the issues labelled as "suggestion"?
Looking at the issues, the tag search (#152) would be the most handy one to have.

But I think my implementation would collide with the work you've already done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants