Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] A biome tag to hide biomes from the compass #156

Open
TelepathicGrunt opened this issue Mar 11, 2023 · 2 comments
Open

Comments

@TelepathicGrunt
Copy link

TelepathicGrunt commented Mar 11, 2023

Some mods/modpacks have biomes that are super rare or special that they may want to hide from the compass to prevent cheesing/breaking balance. The best way to handle this would be to add a Biome Tag that modpack makers or mods can add their special biomes to in order to hide from the compass. If a player wishes to undo that, they can override the tag with a replace:true empty tag to show all biomes again.

The biome tag can be something along the lines of naturescompass:hidden_from_compass and be placed under data/naturescompass/tags/worldgen/biome/hidden_from_compass.json

This would be for 1.18.2 and newer Mc version as biome tags were introduced in 1.18.2.

@MattCzyr
Copy link
Owner

The current way to hide biomes from the compass is through the biome blacklist in the config file. I think it may be confusing to have two systems that basically accomplish the same thing, however I can see how biome tags might be useful, as biomes could then be hidden at the mod level, by the mod developer, and not just at the modpack level. I'll think about this.

@TelepathicGrunt
Copy link
Author

Hmm. Wondering if maybe adding a BiomeBlacklistDataSource config option that has three states of: “ConfigOnly”, “TagOnly”, “Both” and is defaulted to “Both”. (And the comment explains what values are allowed and what it does) That way it is a little more clear to users what the source of the blacklist is and can change it to just the config or tag if they wish. Thus not needing a datapack to disable the tags if they want to handle it through just the config regardless of other mod’s tags. Just throwing ideas out there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants