Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Flags based on OpenFeature Specs #70

Merged
merged 22 commits into from Jun 7, 2022
Merged

Conversation

sarbagya-acme
Copy link
Contributor

@sarbagya-acme sarbagya-acme commented Jun 6, 2022

More about the specs at: https://openfeature.dev

The coverage for some of the OpenFeature files are ignored, as there are some pending feature to be refined as per the spec, which will be done in follow up PRs.

@sarbagya-acme sarbagya-acme marked this pull request as draft June 7, 2022 13:12
@sarbagya-acme
Copy link
Contributor Author

sarbagya-acme commented Jun 7, 2022

Working on fixing tests.

@sarbagya-acme sarbagya-acme marked this pull request as ready for review June 7, 2022 15:57
@codecov
Copy link

codecov bot commented Jun 7, 2022

Codecov Report

Merging #70 (9a746d5) into develop (d2ddca0) will increase coverage by 0.12%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop      #70      +/-   ##
===========================================
+ Coverage    97.62%   97.74%   +0.12%     
===========================================
  Files           69       81      +12     
  Lines         1345     1510     +165     
===========================================
+ Hits          1313     1476     +163     
- Misses          32       34       +2     
Impacted Files Coverage Δ
example/lib/asset_feature_provider.dart 100.00% <100.00%> (ø)
example/lib/home_page.dart 100.00% <100.00%> (ø)
example/lib/main.dart 100.00% <100.00%> (ø)
...ts/feature_provider/engine/open_feature_flags.dart 100.00% <100.00%> (ø)
...faults/feature_provider/json_feature_provider.dart 100.00% <100.00%> (ø)
...c/open_feature/src/core/enums/flag_value_type.dart 100.00% <100.00%> (ø)
lib/src/open_feature/src/core/enums/reason.dart 100.00% <100.00%> (ø)
lib/src/open_feature/src/core/features.dart 100.00% <100.00%> (ø)
.../src/open_feature/src/core/resolution_details.dart 100.00% <100.00%> (ø)
...ure/src/evaluation_context/evaluation_context.dart 100.00% <100.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2ddca0...9a746d5. Read the comment docs.

@MattHamburger MattHamburger merged commit 6e16dce into develop Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

For features expose a way to lookup a feature state without using the feature widget
3 participants