Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

You should be using a full-function Either from fpdart, not the weak limited one you have #95

Closed
RandalSchwartz opened this issue Dec 27, 2022 · 1 comment
Closed

You should be using a full-function Either from fpdart, not the weak limited one you have #95

RandalSchwartz opened this issue Dec 27, 2022 · 1 comment

Comments

@RandalSchwartz
Copy link

Noticed you're not using fpdart's Either. It has more rigor, is better documented, and has a lot more functionality than the choice you've made for a package. I could try to construct a PR if you're interested...
@sarbagya-acme
Copy link
Contributor

@RandalSchwartz Thanks for the suggestion.

Our usage of Either is quite limited so we recently opted for own implementation rather than depending on other package. #94

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RandalSchwartz @sarbagya-acme