Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crashes when swiping from last panel #26

Closed
orenk86 opened this issue Sep 24, 2014 · 3 comments
Closed

crashes when swiping from last panel #26

orenk86 opened this issue Sep 24, 2014 · 3 comments

Comments

@orenk86
Copy link

orenk86 commented Sep 24, 2014

Hi,
First of all, I have to say I'm really digging this library! :)
When I'm on the last panel, and I try to swipe to the next one, the app crashes with the error: index 3 beyond bounds [0 .. 2].
Any way of fixing this? Thanks!

@MatthewYork
Copy link
Owner

hmmm... Let me take a look.

@orenk86
Copy link
Author

orenk86 commented Oct 6, 2014

I think I figured out what went wrong.... :)
I'm trying to create a circular scroll between the panels, that can also support swiping (not just automatic scroll to the next panel every few seconds).
But when you swipe left from the last panel, the intro view "finishes" and disappears. Afterwards when it tries to move to the next (first) panel - the app crashes (because the pager isn't there anymore).

Is there any chance you might consider creating support for circular swiping between the last and first panels, instead of "finishing the intro"?
or alternately, have an option to prevent further swiping when you're on the last panel (you can swipe to the previous panel, but not to the next)?

@MatthewYork
Copy link
Owner

Glad you pinpointed the crash!

I think circular swiping would be a great mode to have available. It would certainly make the controller more flexible for non-introduction related tasks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants