Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty Queue and Min_age edge case #82

Open
officiallymarky opened this issue May 20, 2018 · 1 comment
Open

Empty Queue and Min_age edge case #82

officiallymarky opened this issue May 20, 2018 · 1 comment

Comments

@officiallymarky
Copy link
Contributor

I ran into an edge case that might be a simple fix if you have a few minutes you are mad at. It's not a critical issue, but I will leave it here anyway.

I have a smaller bot I help someone run, and it isn't uncommon for it to have zero bids at 100% due to the smaller size and 10% reward cap. It also has a min_age of 20 minutes, fairly typical of bots these days.

There is a scenario that may happen where a user submits a post that is 19 or fewer minutes old, and the bot currently has no bids and is at or near 100%.

The bid will be lost in limbo "next round queue" even when the post hits 20 minutes old due to the fact no further checks are made until another bid comes in. It will then execute that bid and then push the post from the next round to current round.

While this is a rare edge case it's something to think about. Not really critical and may never need to be fixed but mentioning it so I can get it off my mental plate and put it somewhere.

@pjau86
Copy link

pjau86 commented Jun 13, 2018

I ran into this issue today. My friend sent another bid and it kickstarted it like you said.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants