Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate proguard rules inside the library folder #52

Closed
peterbetos opened this issue Oct 11, 2016 · 6 comments
Closed

Integrate proguard rules inside the library folder #52

peterbetos opened this issue Oct 11, 2016 · 6 comments
Assignees
@Mauker1
Labels
enhancement
Milestone
1.2.0

Comments

@peterbetos
Copy link

peterbetos commented Oct 11, 2016 •
edited

Would you be able to apply the following:
http://stackoverflow.com/a/30801516/1931228
This is to prevent apps from forgetting to integrate the proguard rules.

I'll be using your version of the library since it's currently full-featured. (Kudos 👍 )
I'll stop updating my fork 😃
@Mauker1 Mauker1 self-assigned this Oct 11, 2016
@Mauker1 Mauker1 added this to the 1.2.0 milestone Oct 11, 2016
@Mauker1
Copy link
Owner

Mauker1 commented Oct 11, 2016

Oh, very nice idea! I'll take a look into that. Thanks!

@Mauker1 Mauker1 modified the milestones: 1.2.1, 1.2.0 Oct 28, 2016
@Mauker1 Mauker1 reopened this Oct 28, 2016
@Mauker1
Copy link
Owner

Mauker1 commented Oct 28, 2016

@peterbetos Care to take a look at this and help me figure out what went wrong? I'm not very good with proguard.
I'm postponing this issue to 1.2.1 as I want to release 1.2.0 now.

@peterbetos
Copy link
Author

Sure @Mauker1 will check this.

@Mauker1
Copy link
Owner

Mauker1 commented Oct 28, 2016

I wasn't expecting to see you so soon haha.
Well, Maybe it can be on 1.2.0 after all 👍

@Mauker1 Mauker1 modified the milestones: 1.2.0, 1.2.1 Oct 28, 2016
@Mauker1
Copy link
Owner

Mauker1 commented Oct 28, 2016

Solved with the last PR. Thanks @peterbetos 👍
Btw, I've added your name on the contributors list 😄

@Mauker1 Mauker1 closed this as completed Oct 28, 2016
@peterbetos
Copy link
Author

Nice. Thanks @Mauker1 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mauker1 Mauker1

Labels
enhancement
Projects
None yet
Milestone
1.2.0
Development

No branches or pull requests
2 participants
@Mauker1 @peterbetos