Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vibrancy issue #33

Open
Nivl opened this issue Nov 23, 2018 · 1 comment
Open

Vibrancy issue #33

Nivl opened this issue Nov 23, 2018 · 1 comment

Comments

@Nivl
Copy link

Nivl commented Nov 23, 2018

I tried using vibrancy (light) on a panel, but it doesn't seem to be working: the panel appears white-ish instead (but fully opaque). I tried running the ShowReel demo, and it's the same, everything looks white, including the modal (and clicking around made my CPU go 200%+).

data-vibrancy also doesn't seem to be doing anything. The following snippet works when setting vibrancy to light in the option of BrowserWindow but doesn't (= appears white) when using the data-vibrancy prop of ph-window:

<ph-window>
    <window-content>
        <nav-group>
            <nav-item>connors</nav-item>
            <nav-item>Downloads</nav-item>
            <nav-item>Documents</nav-item>
            <nav-item>AirPlay</nav-item>
            <nav-item>Applications</nav-item>
            <nav-item>Desktop</nav-item>
        </nav-group>
    </window-content>
</ph-window>

Then when using a sidebar (or any panel) with BrowserWindow's vibrancy option, the sidebar turns white but the right side does has vibrancy.

      <ph-window>
        <window-content>
          <div className="pane-group">
            <div className="pane-sm sidebar">
              <nav-group>
                <nav-item>connors</nav-item>
                <nav-item>Downloads</nav-item>
                <nav-item>Documents</nav-item>
                <nav-item>AirPlay</nav-item>
                <nav-item>Applications</nav-item>
                <nav-item>Desktop</nav-item>
              </nav-group>
            </div>
        </window-content>
      </ph-window>

Here's a screenshot of ShowReel, which doesnt look as it should be (tested with electron 3.0.10).

screen shot 2018-11-23 at 2 57 10 am

@MauriceConrad
Copy link
Owner

Hm, I tested it with the newest electron release and found the following issues:

  1. If you do not use the Developer-Tools (or in a second window), the sidebar appears vibrancy on macOS mojave 10.14.2
  2. A dialog currently has no vibrancy.

The bug did not happened before in earlier electron versions. I will try to fix it soon as possible...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants