Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leave K out split train validation, leaves some data out for validation even when the flag use_validation_set is False. #16

Open
pm390 opened this issue Aug 12, 2022 · 0 comments

Comments

@pm390
Copy link

pm390 commented Aug 12, 2022

The interested file is this one:
RecSys_Course_AT_PoliMi/Data_manager/split_functions/split_train_validation_leave_k_out.py
lines 88 and 89.

Even if we set use_validation_set=False the validation data is held out (and used nowhere):

user_interaction_items_train = user_interaction_items[k_out*2:]
user_interaction_data_train = user_interaction_data[k_out*2:]

A possible change would be:

split_point= k_out*2 if use_validation_set else k_out
user_interaction_items_train = user_interaction_items[split_point:]
user_interaction_data_train = user_interaction_data[split_point:]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant