Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash attempting to merge a finalised model - version folder #463

Open
OButlerOcc opened this issue May 15, 2024 · 3 comments
Open

Crash attempting to merge a finalised model - version folder #463

OButlerOcc opened this issue May 15, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@OButlerOcc
Copy link
Contributor

OButlerOcc commented May 15, 2024

Versioned folders allow you to merge a finalised branch which causes a comparison error

Create the following:
image

  1. one tagged finalised branch,

  2. one non finalised main branch

  3. one other branch.

  4. go to merge on the testbranch

image

  1. select the finalised branch that appears in the merge screen.

image

  1. note the crash and error that occurs during the merge diff calculation.
@OButlerOcc OButlerOcc added the bug Something isn't working label May 15, 2024
@OButlerOcc OButlerOcc self-assigned this May 15, 2024
@jamesrwelch
Copy link
Contributor

@OButlerOcc Do you have a stack trace?

@pjmonks
Copy link
Contributor

pjmonks commented May 16, 2024

Isn't the issue more that the list of available branches to merge into includes finalised versioned folders?

The branch selector component in the UI is calling the GET /api/versionedFolders/{id}/simpleModelVersionTree?branchesOnly=true. For data models this returns just the draft branches, perhaps there is an issue with the versionedFolder domain endpoint - maybe the branchesOnly parameter is ignored? Something to look into.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Backlog
Development

No branches or pull requests

3 participants