Links from the description field are not valid URLs

[pjmonks]

Description

When testing on the NHS Data Dictionary instance - https://modelcatalogue.cs.ox.ac.uk/nhsd-datadictionary/ - the hyperlinks in the description fields of an item are just the Mauro path, but are not valid URLs to redirect to.

Steps to reproduce

Go to an item, like this: https://modelcatalogue.cs.ox.ac.uk/nhsd-datadictionary/#/catalogue/dataClass/6d054bbe-e634-45ee-837a-ed7f83c3f77c//15deb5ca-e327-4f5a-b240-eedfdd5e3fd3/description

Notice that the description field contains what looks like hyperlinks:

However, copy the link address from any of these links e.g. "ACCOMODATION", and this is the exact href from the <a> tag:

dm:Classes and Attributes|dc:Classes|dc:ACCOMMODATION

Click on these links, and the browser will not know what to do.

Expected behavior

These hyperlinks should be valid URLs to redirect to.

Related Issues

The fix for this is related to these issues:

• Rewrite internal Mauro path URLs for HTML content #860
• MauroDataMapper-NHSD/mdm-plugin-nhs-data-dictionary#11

[pjmonks]

I feel like I have worked on these links previous (perhaps with the Markdown editor, not the HTML version) - there may be existing PRs in this repo related to updates I worked on for hyperlinks, but we will need to locate them.

[jamesrwelch]

We certainly did some work in this space - it may be that the ingest / publication needs aligning with whatever works through the UI. Definitely an issue to get sorted though

[pjmonks]

My initial testing shows that creating a hyperlink to a Mauro item manually through the UI works fine and generates a valid URL reference. The next step would be to inspect the DD ingest code like @jamesrwelch suggested, this is probably where the incorrect URLs are being generated.

[pjmonks]

Based on feedback about the ingest of the DD and links, I've created:

• Rewrite internal Mauro path URLs for HTML content #860

This will keep links as paths but allow them to be displayed correctly.