Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge a "main" branch into a separate branch of a model or versioned folder #854

Open
pjmonks opened this issue Apr 16, 2024 · 4 comments · May be fixed by #863
Open

Merge a "main" branch into a separate branch of a model or versioned folder #854

pjmonks opened this issue Apr 16, 2024 · 4 comments · May be fixed by #863
Assignees
Labels
enhancement New feature or request

Comments

@pjmonks
Copy link
Contributor

pjmonks commented Apr 16, 2024

Description

At the moment, you can only merge changes from a model/versioned folder from a new branch back into the "main" branch (draft) model/versioned folder, but you cannot do this the other way around. For example, in this scenario:

image

  • You can select the "Merge" option to merge branch "CR8000" to "main"
  • You currently cannot merge "main" to "CR8000"

The second case is important too because changes may have been made to "main" whilst the other branch has been idle or worked on, so the latest "main" changes should be able to be committed back to the other branch for consistency.

@OButlerOcc
Copy link
Contributor

Not a ui change, actually a security change see Pr: MauroDataMapper/mdm-core#460

@OButlerOcc OButlerOcc reopened this May 9, 2024
@OButlerOcc
Copy link
Contributor

Reopened for a question, I can now merge a main Version Folder into other branches, Do I want to also be able to merge individual models inside? Security policies seems to indicate folder only but task is a tad ambigious on this

@jamesrwelch
Copy link
Contributor

@OButlerOcc I would say it only really makes sense to merge whole VFs at a time - if you were to merge single models within a VF you'd likely end up with dangling links - references to things that didn't exist.

@pjmonks
Copy link
Contributor Author

pjmonks commented May 9, 2024

@OButlerOcc and @jamesrwelch - I think if I remember correctly, a merge diff is allowed on a standalone model so long as it is not inside a versioned folder - the VF takes precedence over sub-models within it. So a merge, either as main -> branch, or branch -> main, should apply to:

  • Models (Data Model, Terminology, Code Sets etc) not inside a VF
  • Versioned Folders
  • But not models inside a Versioned Folder

@pjmonks pjmonks linked a pull request May 16, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants