Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a config option for the default music bot volume #71

Closed
Jokler opened this issue Oct 14, 2020 · 0 comments · Fixed by #77
Closed

Add a config option for the default music bot volume #71

Jokler opened this issue Oct 14, 2020 · 0 comments · Fixed by #77
Labels
feature New feature or request good first issue Good for newcomers
Projects
Milestone

Comments

@Jokler
Copy link
Member

Jokler commented Oct 14, 2020

Is your feature request related to a problem? Please describe.
When a music bot it has a default volume preset, this volume is often too loud.

Describe the solution you'd like
A config option would allow the default volume to be changed per server.

Describe alternatives you've considered
Lower the default volume for everyone but since this is subjective I am against it.

Relevant line

player.change_volume(VolumeChange::Absolute(0.5)).unwrap();

@Jokler Jokler added feature New feature or request good first issue Good for newcomers labels Oct 14, 2020
@Jokler Jokler added this to To do in General via automation Oct 14, 2020
@Jokler Jokler added this to the 0.3.0 milestone Oct 15, 2020
@fkaa fkaa closed this as completed in #77 Oct 24, 2020
General automation moved this from To do to Done Oct 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request good first issue Good for newcomers
Projects
General
  
Done
Development

Successfully merging a pull request may close this issue.

1 participant