Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Formula struct, fix other model types #61

Merged
merged 2 commits into from May 2, 2019
Merged

Conversation

MaxDesiatov
Copy link
Collaborator

@MaxDesiatov MaxDesiatov commented May 2, 2019

Fix #50
Fix #59

@codecov
Copy link

codecov bot commented May 2, 2019

Codecov Report

Merging #61 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #61   +/-   ##
=======================================
  Coverage   98.49%   98.49%           
=======================================
  Files           6        6           
  Lines         266      266           
=======================================
  Hits          262      262           
  Misses          4        4
Impacted Files Coverage Δ
Sources/CoreXLSX/Worksheet/Worksheet.swift 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6d4022...b3df0db. Read the comment docs.

@MaxDesiatov MaxDesiatov merged commit ec8d671 into master May 2, 2019
@delete-merged-branch delete-merged-branch bot deleted the formula-fix branch May 2, 2019 18:08
@MaxDesiatov MaxDesiatov mentioned this pull request May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error Domain=NSCocoaErrorDomain Code=4865 "Expected String but found null instead." error parseWorksheet
2 participants