Can this be generalized?

[vsoch]

Heyo! I found yamp and it had an install error from pypi, so then I found your project here and tried it out - but it looks like it's hard coded for river?

yamp/yamp/__init__.py

Line 28 in 03a0c95

inspect.getmembers(importlib.import_module("river"), inspect.ismodule)

So my question is - can this be generalized for any module since we provide the name?

[vsoch]

Looking a bit into the code - it does look like it's hard coded for river. I'll try on my own to refactor to see if I can generalize. Thanks, sorry for the noise!

[vsoch]

oh btw I tried using pytest to run tests directly from my docstrings - life changing!!! 😆

[MaxHalford]

In general this library should be generic! But yeah I kinda copy/pasted the code directly from River, so changes have to be made.

oh btw I tried using pytest to run tests directly from my docstrings - life changing!!! 😆

I know right!

[MaxHalford]

Just removed the remaining mentions of river.