Skip to content
This repository has been archived by the owner on Apr 10, 2023. It is now read-only.

Make example project consume pod via Podfile again. #6

Merged
merged 1 commit into from Feb 27, 2014

Conversation

ayanonagon
Copy link
Contributor

I know this looks like a big PR, but all I did is remove the duplicate Luhn.h and Luhn.m in the example project and move its contents to the other copies in Algorithm Class which is where the podspec is looking for the files. (So the new stuff you wrote today is in now in the Algorithm Class directory.)

You don't need to worry about keeping the old copies of the Luhn classes because Cocoapods uses git tags to keep track of which version to use.

When you pull this, make sure to run pod install from the Example Project directory. I've made sure the example app and tests run.

Let me know if you have any questions!

:octocat:

@maxkramer
Copy link
Owner

@ayanonagon completely understand, I'm going to test it just to make sure, but great work.

maxkramer pushed a commit that referenced this pull request Feb 27, 2014
Make example project consume the Objective-Luhn pod via Podfile again.
@maxkramer maxkramer merged commit 212435d into maxkramer:master Feb 27, 2014
@ayanonagon
Copy link
Contributor Author

Woo hoo! When you feel like releasing v1.1.0, it might be good to rename Algorithm Class to something like ObjectiveLuhn and point the podspec source to that. Great work with the card detection stuff. 👍

@maxkramer
Copy link
Owner

Thanks, will do, plan on doing it this weekend if I get a chance :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants