Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor wording change for "Download" link #23

Merged
merged 1 commit into from Mar 14, 2022

Conversation

emilyst
Copy link
Contributor

@emilyst emilyst commented Mar 12, 2022

Suggesting this change simply because "ZIP" appears to be (per its specification published by PKWARE) canonically spelled uppercase.

I also added the word "archive" to provide a noun modified by "ZIP" rather than treating "ZIP" as a noun itself. It seems clearer this way, but may cause text flow issues in the design if it's too long.

@vercel
Copy link

vercel bot commented Mar 12, 2022

Someone is attempting to deploy a commit to a Personal Account owned by @MaxLeiter on Vercel.

@MaxLeiter first needs to authorize it.

@vercel
Copy link

vercel bot commented Mar 12, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/mleiter/drift/5Ujp78L9tm73HDWRzw2nrGe8bbyg
✅ Preview: https://drift-git-fork-emilyst-patch-1-mleiter.vercel.app

@MaxLeiter
Copy link
Owner

MaxLeiter commented Mar 13, 2022

Screenshot showing the badge and title being vertically above the download button

diff --git a/client/pages/post/[id].tsx b/client/pages/post/[id].tsx
index a92f623..58e8d27 100644
--- a/client/pages/post/[id].tsx
+++ b/client/pages/post/[id].tsx
@@ -8,6 +8,7 @@ import Header from "../../components/header";
 import VisibilityBadge from "../../components/visibility-badge";
 import { ThemeProps } from "../_app";
 import Head from "next/head";
+import styles from './styles.module.css';
 
 const Post = ({ theme, changeTheme }: ThemeProps) => {
     const [post, setPost] = useState<any>()
@@ -80,7 +81,7 @@ const Post = ({ theme, changeTheme }: ThemeProps) => {
                     <Document skeleton={true} />
                 </>}
                 {!isLoading && post && <>
-                    <div style={{ display: 'flex', justifyContent: 'space-between', alignItems: 'center' }}>
+                    <div className={styles.header}>
                         <Text h2>{post.title} <VisibilityBadge visibility={post.visibility} /></Text>
                         <Button auto onClick={download}>
                             Download as ZIP archive
diff --git a/client/pages/post/styles.module.css b/client/pages/post/styles.module.css
new file mode 100644
index 0000000..5bcfe22
--- /dev/null
+++ b/client/pages/post/styles.module.css
@@ -0,0 +1,11 @@
+.header {
+   display: flex;
+   justify-content: space-between;
+   align-items: center;
+}
+
+@media screen and (max-width: 650px) {
+    .header {
+        flex-direction: column;
+    }
+}
\ No newline at end of file

@emilyst
Copy link
Contributor Author

emilyst commented Mar 14, 2022

Amended to include this patch.

Suggesting this change simply because "ZIP" appears to be (per its specification published by PKWARE) canonically spelled uppercase.

I also added the word "archive" to provide a noun modified by "ZIP" rather than treating "ZIP" as a noun itself. It seems clearer this way, but may cause text flow issues in the design if it's too long.
@MaxLeiter
Copy link
Owner

🎉 thanks @emilyst!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants