Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change post visibility #83

Merged
merged 2 commits into from Apr 14, 2022
Merged

Conversation

jazcarate
Copy link
Collaborator

Closes #64

Again with my awful UI 😅
I tried aligning the buttons to the right, like the UX when creating. Cound't CSS 🙈.
I tried the UX of having a ButtonDropdown but felt... off. Cant really explain.

Test are missing. I know. I started with #79 but got a bit derailed with #64 😳

Change you own post

image

A protected post

image

Seeing another user's post

image

Discussion point

It is weird that the links to the posts depend on the visibility. Now that we can change it, links will break.
Say I send you a link to http://drift/post/**protected**/91b769ab-b96e-4222-8501-95b0749a920e or http://drift.com/post/**private**/91b769ab-b96e-4222-8501-95b0749a920e, but then make it public; the old link will break.
I think any visibility should check the post ID and redirect accordingly to the current visibility.

@MaxLeiter
Copy link
Owner

MaxLeiter commented Apr 9, 2022

I'll comment on some ideas for an improved UX when I think on it some more, but as a response to It is weird that the links to the posts depend on the visibility.: I agree, and it's actually not necessary anymore. I did that as public and unlisted posts can be SSG, which I removed to simplify the Docker setup, so now there's no real reason they can't all be /post/:id

@MaxLeiter
Copy link
Owner

@jazcarate I've removed the /protected and /private post sub-URLs. All posts are now under the /post/:id scheme.

67e1b98

@jazcarate
Copy link
Collaborator Author

I removed the margin of that button group (see image)
I added a delay loading
Made the visibility prop change; rather than the router recalculate
Made buttons be disabled, rather than appear and disappear when you change visibility

image

@MaxLeiter
Copy link
Owner

Looks great! Can you move the ButtonGroup to the right-side, similar to when creating a post?

I think this will eventually be moved to a proper edit page once I figure out post revisions, but it's great to have the functionality now.

@jazcarate
Copy link
Collaborator Author

Done :)
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability to change post visibility
2 participants