Fixed handling of parameters with names that are keys in Object.proto…

…type.
MaxNanasy · May 25, 2012 · ec28f81 · ec28f81
1 parent 6014c13
commit ec28f81
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/querystring.js b/querystring.js
@@ -145,7 +145,7 @@ QueryString.parse = QueryString.decode = function(qs, sep, eq) {
     var k = QueryString.unescape(x[0], true);
     var v = QueryString.unescape(x.slice(1).join(eq), true);
 
-    if (!(k in obj)) {
+    if (!(obj.hasOwnProperty(k))) {
       obj[k] = v;
     } else if (!Array.isArray(obj[k])) {
       obj[k] = [obj[k], v];

diff --git a/test-querystring.js b/test-querystring.js
@@ -26,7 +26,8 @@ var qsTestCases = [
      'undef': ''}],
   [' foo = bar ', '%20foo%20=%20bar%20', {' foo ': ' bar '}],
   ['foo=%zx', 'foo=%25zx', {'foo': '%zx'}],
-  ['foo=%EF%BF%BD', 'foo=%EF%BF%BD', {'foo': '\ufffd' }]
+  ['foo=%EF%BF%BD', 'foo=%EF%BF%BD', {'foo': '\ufffd' }],
+  ['toString=bar', 'toString=bar', {'toString': 'bar'}]
 ];
 
 // [ wonkyQS, canonicalQS, obj ]